feat: search order by final #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+291
to
+292
| .whereBetween('final_rank', [offset + 1, offset + limit]) | ||
| .orderBy('final_rank'); |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
FeatureSearchStore.searchFeatures already has high cyclomatic complexity, and now it increases in Lines of Code from 227 to 228
sjaanus
added a commit
that referenced
this pull request
May 3, 2024
Final rank has always been ordering correctly by default. But after 5.12 I see some issues that sometimes it is not ordered. Just to be extra sure, I am for ordering it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final rank has always been ordering correctly by default. But after 5.12 I see some issues that sometimes it is not ordered. Just to be extra sure, I am for ordering it.