feat: Allow to use CA certificate file path for DB #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@egor-xyz is attempting to deploy a commit to the unleash-team Team on Vercel. A member of the Team first needs to authorize it. |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -1,7 +1,6 @@ | |||
| import { parse } from 'pg-connection-string'; | |||
| import merge from 'deepmerge'; | |||
| import * as fs from 'fs'; | |||
| import { readFileSync } from 'fs'; | |||
| import { readFileSync, existsSync } from 'fs'; | |||
There was a problem hiding this comment.
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.28 to 5.24, threshold = 4
|
FYI @chriswk @sighphyre |
chriswk
approved these changes
May 6, 2024
There was a problem hiding this comment.
Nice. I like it. @ivarconr @sighphyre can you see anything wrong with applying Egor's patch? This allows adding only a CA, which I think is a good way to go.
Thank you @egor-xyz
chriswk
pushed a commit
that referenced
this pull request
May 7, 2024
Regarding ticket #6892: I would like to enable the use of a CA certificate without requiring other certificates. This would be useful for AWS Helm, as AWS only provides a single PEM file for DB connections.
chriswk
added a commit
that referenced
this pull request
May 8, 2024
We'd like to get this out so you can get away with only defining a CA certificate, the current iteration requires CA, CERT and KEY in order to work. This PR splits it up and allows you to configure one. --------- Co-authored-by: Egor Stronhin <6418221+egor-xyz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding ticket #6892:
I would like to enable the use of a CA certificate without requiring other certificates. This would be useful for AWS Helm, as AWS only provides a single PEM file for DB connections.