fix: remove columns from the search api query #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
May 7, 2024
| @@ -86,10 +86,11 @@ export const ProjectFeatureToggles = ({ | |||
| createdAt: tableState.createdAt, | |||
| }; | |||
|
|
|||
| const { columns: _, ...apiTableState } = tableState; | |||
There was a problem hiding this comment.
omit columns and rename to _ to avoid name clash with the existing columns variable
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
kwasniew
commented
May 7, 2024
| @@ -119,7 +120,6 @@ export const ProjectFeatureToggles = ({ | |||
| setFeatureArchiveState, | |||
| setFeatureStaleDialogState, | |||
| } = useRowActions(refetch, projectId); | |||
| const [showExportDialog, setShowExportDialog] = useState(false); | |||
sjaanus
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When selecting columns to display in the UI we want to persist them in the URL for sharing but we don't want to send them to the API and generate unnecessary SWR request keys.
Also removed unused project overview component and unused variable.
Important files
Discussion points