-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kept and discarded read model #7045
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@@ -43,7 +43,10 @@ export const populateCurrentStage = ( | |||
case 'completed': | |||
return { | |||
name: 'completed', | |||
status: 'kept', | |||
status: | |||
feature.lifecycle.status === 'discarded' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
special case for discarded, other states use green icon
@@ -10,8 +10,8 @@ import type { StageName } from '../../types'; | |||
type DBType = { | |||
stage: StageName; | |||
created_at: string; | |||
status?: string; | |||
status_value?: string; | |||
status: string | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in DB the column is nullable
@@ -62,6 +66,11 @@ const getFeatureLifecycle = async (featureName: string, expectedCode = 200) => { | |||
.get(`/api/admin/projects/default/features/${featureName}/lifecycle`) | |||
.expect(expectedCode); | |||
}; | |||
|
|||
const getCurrentStage = async (featureName: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added new method to test the read model directly inside this module
About the changes
Important files
Discussion points