test: fix flaky lifecycle test #7093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
May 21, 2024
| @@ -98,7 +98,8 @@ const uncompleteFeature = async (featureName: string, expectedCode = 200) => { | |||
| function reachedStage(feature: string, stage: StageName) { | |||
| return new Promise((resolve) => | |||
| featureLifecycleService.on(STAGE_ENTERED, (event) => { | |||
| if (event.stage === stage) resolve(stage); | |||
| if (event.stage === stage && event.feature === feature) | |||
There was a problem hiding this comment.
when you introduce feature to a method signature that would be cool if you used it :)
There was a problem hiding this comment.
wow! I totally missed it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adding feature name check when reaching a certain lifecycle stage to check if we're looking at the right thing.
Important files
Discussion points