fix: don't send change request info unless using the new form

frontend/src/component/project/Project/CreateProject/CreateProjectDialog/CreateProjectDialog.tsx

@@ -75,11 +75,16 @@ export const CreateProjectDialogue = ({
     const clearDocumentationOverride = () =>
         setDocumentation(generalDocumentation);
 
+    const projectPayload = getCreateProjectPayload({
+        omitId: true,
+        includeChangeRequestConfig: true,
+    });
+
     const formatApiCode = () => {
         return `curl --location --request POST '${uiConfig.unleashUrl}/api/admin/projects' \\
 --header 'Authorization: INSERT_API_KEY' \\
 --header 'Content-Type: application/json' \\
---data-raw '${JSON.stringify(getCreateProjectPayload(), undefined, 2)}'`;
+--data-raw '${JSON.stringify(projectPayload, undefined, 2)}'`;
     };
 
     const handleSubmit = async (e: Event) => {
@@ -88,11 +93,8 @@ export const CreateProjectDialogue = ({
         const validName = validateName();
 
         if (validName) {
-            const payload = getCreateProjectPayload({
-                omitId: true,
-            });
             try {
-                const createdProject = await createProject(payload);
+                const createdProject = await createProject(projectPayload);
                 refetchUser();
                 navigate(`/projects/${createdProject.id}`, { replace: true });
                 setToastData({

frontend/src/component/project/Project/hooks/useProjectForm.test.ts

@@ -35,3 +35,29 @@ test(`adding a change request config for an env not in the project envs doesn't
         'dev' in result.current.projectChangeRequestConfiguration,
     ).toBeFalsy();
 });
+
+describe('payload generation', () => {
+    test(`id is omitted only when explicitly asked to be`, () => {
+        const { result } = renderHook(() => useProjectForm());
+
+        const payloadWithId = result.current.getCreateProjectPayload();
+        expect('id' in payloadWithId).toBeTruthy();
+
+        const payloadWithoutId = result.current.getCreateProjectPayload({
+            omitId: true,
+        });
+        expect('id' in payloadWithoutId).toBeFalsy();
+    });
+});
+
+describe('name validation', () => {
+    test.each([
+        ['An empty string', ''],
+        ['Just whitespace', '     '],
+    ])(`%s is not valid`, (_, value) => {
+        const { result } = renderHook(() => useProjectForm());
+
+        result.current.setProjectName(value);
+        expect(result.current.validateName()).toBeFalsy();
+    });
+});

frontend/src/component/project/Project/hooks/useProjectForm.ts

@@ -94,7 +94,10 @@ const useProjectForm = (
         setProjectMode(initialProjectMode);
     }, [initialProjectMode]);
 
-    const getCreateProjectPayload = (options?: { omitId?: boolean }) => {
+    const getCreateProjectPayload = (options?: {
+        omitId?: boolean;
+        includeChangeRequestConfig?: boolean;
+    }) => {
         const environmentsPayload =
             projectEnvironments.size > 0
                 ? { environments: [...projectEnvironments] }
@@ -119,7 +122,9 @@ const useProjectForm = (
             ? {
                   ...ossPayload,
                   mode: projectMode,
-                  changeRequestEnvironments,
+                  ...(options?.includeChangeRequestConfig
+                      ? { changeRequestEnvironments }
+                      : {}),
               }
             : ossPayload;
     };