fix: make dialog the right height and make it scroll if it's smaller #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've marked the project creation dialog as "compact", so that it's only as tall as it needs to be.
However, by default, compact forms don't scroll because they have overflow set to hidden. This is a problem on very short windows. To get around this, I've set overflow to unset on compact forms.
I've also removed
min-height: 0which has some weird side effects on the centered dialog. Instead, I'm settingmin-heighttounsetif it's compact.This task also uncovered some inconsistencies and some borders that only show up sometimes, so I've removed them too.