feat: Navigation switch #7132
Merged
feat: Navigation switch #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
May 23, 2024
| paddingTop: theme.spacing(2), | ||
| paddingBottom: theme.spacing(6), | ||
| height: '100%', | ||
| position: 'absolute', |
There was a problem hiding this comment.
removes sidebar from regular flow
There was a problem hiding this comment.
I'm not sure about this change, since I'd like the content area to have the same padding on all sides when the sidebar is active. But let's see how it plays out.
FredrikOseberg
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Simple show/hide switch to have keyboard navigation
Also changed positioning to absolute so that the project search content doesn't escape the parent and the show main content is not shifted on resizing of the sidebar. As a result we need a way to overlay the sidebar over the content on smaller screens.
Important files
Discussion points