feat: add db-session store #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some concerns regarding how to handle this properly for tests, we mentioned adding a new option as to whether or not we're using a db backed session store. We should also scrap the cookie-session and |
chriswk
force-pushed
the
feat-session-db-store
branch
from
fb578d9
to
b8091fa
Compare
|
Will the store go to database everytime, or is it possible to have some local in-mem cache for hot sessions? If yes we need to think about how logout should work to invalidate local cache. If no we need to do some performance testing to make sure we are not overloading the db |
chriswk
force-pushed
the
feat-session-db-store
branch
from
b8091fa
to
2c21c73
Compare
chriswk
force-pushed
the
feat-session-db-store
branch
2 times, most recently
from
3a62ddc
to
7dede72
Compare
chriswk
force-pushed
the
feat-session-db-store
branch
from
e08e706
to
4486099
Compare
ivarconr
reviewed
Feb 17, 2021
src/lib/options.js
Outdated
| @@ -81,6 +81,7 @@ function defaultOptions() { | |||
| version, | |||
| secureHeaders: process.env.SECURE_HEADERS || false, | |||
| enableOAS: process.env.ENABLE_OAS || false, | |||
| dbSession: process.env.DB_SESSION || true, | |||
There was a problem hiding this comment.
could we introduce a session section? { session: { db: true }}
There was a problem hiding this comment.
Sure, and move maxAge in there as well then?
There was a problem hiding this comment.
introduced in a9c198d
chriswk
force-pushed
the
feat-session-db-store
branch
from
4486099
to
f6cf1a2
Compare
ivarconr
approved these changes
Feb 17, 2021
Tymek
pushed a commit
that referenced
this pull request
Aug 26, 2022
* feat: setup new screen structure * refactor: strategyParameter * feat: add strategy input errors for required fields * feat: add create strategy to routes * feat: add EditStrategy component * feat: edit strategy view and EditStrategy component * feat: update EditStrategy component * test: update snapshots * fix: styles * test: update snapshots * refactor: rename StrategyForm and fix ts errors * test: update snapshots * fix: remove test route * fix: update PR based on feedback * fix: update PR based on feedback * refactor: restore feature settings (#712) * refactor: resotre feature settings * fix: update PR based on feedback * feat: add feature information in Metadata container * fix: update PR based on feedback * fix: update PR based on feedback Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com> * chore(deps): update dependency @types/react-dom to v17.0.13 * refactor: expect existing TS errors (#767) * refactor: expect existing TS errors * refactor: fail build on new TS errors * fix: styles * refactor: rename StrategyForm and fix ts errors * fix: update PR based on feedback * fix: cleaning up * fix: remove errors and warnings * fix: remove ts-expect-error and fix errors * fix: ts errors * Update src/component/strategies/StrategyView/StrategyView.tsx * Update src/component/strategies/StrategyView/StrategyView.tsx Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: olav <mail@olav.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.