feat: command bar pages and name resolving #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
reviewed
Jun 14, 2024
| projectId, | ||
| key, | ||
| }: { projectId: string; key: string }) => { | ||
| const { project, loading } = useProjectOverview(projectId); |
There was a problem hiding this comment.
Hmm downside of this is that every time they open the menu, we will make 1-5 concurrent calls to backend. But for now it is fine.
There was a problem hiding this comment.
Yup, unfortunately
sjaanus
approved these changes
Jun 14, 2024
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Resolves names and icons etc for pages, features, and projects in recently visited
Adds a Pages suggestion section to command bar (that filters out non-OSS routes for OSS)