chore: add metrics/gauges for "max constraint values" and "max constraints" #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
changed the title
thomasheartman
commented
Jun 14, 2024
src/lib/features/feature-toggle/tests/feature-toggle-strategies-store.e2e.test.ts
Show resolved
Hide resolved
kwasniew
reviewed
Jun 14, 2024
kwasniew
reviewed
Jun 14, 2024
src/lib/features/feature-toggle/feature-strategies-read-model.ts
Outdated
Show resolved
Hide resolved
kwasniew
approved these changes
Jun 14, 2024
thomasheartman
deleted the
chore/1-2483-report-max-number-of-constraint-values-constraints-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics tracking for:
It updates the existing feature strategy read model that returns max metrics for other strategy-related things.
It also moves one test into a more fitting describe block.