feat: added basic email-service #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarconr
reviewed
Apr 8, 2021
src/lib/routes/admin-api/email.js
Outdated
| super(config); | ||
| this.emailService = emailService; | ||
| this.logger = config.getLogger('routes/admin-api/email'); | ||
| this.get('/preview/html/:template', this.getHtmlPreview); |
There was a problem hiding this comment.
Maybe require "ADMIN" permission for these endpoints?
There was a problem hiding this comment.
Good point, will add
ivarconr
reviewed
Apr 8, 2021
ivarconr
approved these changes
Apr 8, 2021
|
Perhaps rename to IAuthOptions to keep the naming convention when you do?
fre. 9. apr. 2021 kl. 10:33 skrev Christopher Kolstad <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In src/lib/services/email-service.ts
<#780 (comment)>:
> +export type AuthOptions = {
+ user: string;
+ password: string;
+};
+
+export enum TemplateFormat {
+ HTML = 'html',
+ PLAIN = 'plain',
+}
+
+export enum TransporterType {
+ SMTP = 'smtp',
+ JSON = 'json',
+}
+
+export type EmailOptions = {
Will revert it back to an interface
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#780 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2WIPURI5G4B7OGQ2CBKEDTH23XPANCNFSM42SIZGNQ>
.
|
Tymek
pushed a commit
that referenced
this pull request
Aug 26, 2022
* feat: create segmentation structure and list * feat: remove unused deps and change route * feat: change header style and add renderNoSegments * fix: style table header * feat: create useSegments hook * feat: add segmentApi hook * feat: create segment * fix: errors * feat: add contextfields list * fix: remove user from create segment api * feat: add form structure * feat: add SegmentFormStepOne * fix: tests and routes * feat: add constraint view * feat: UI to match the sketch * feat: add constraint on context select * fix: duplication * fix adding constraints Co-authored-by: olav <mail@olav.io> * fix: input date not showing up in constraint view Co-authored-by: olav <mail@olav.io> * fix: minor bugs Co-authored-by: olav <mail@olav.io> * fix: create context modal in segment page Co-authored-by: olav <mail@olav.io> * fix: validate constraint before create segment Co-authored-by: olav <mail@olav.io> * feat: create useSegment hook Co-authored-by: olav <mail@olav.io> * feat: create edit component Co-authored-by: olav <mail@olav.io> * refactor: move constraint validation endpoint * refactor: add missing route snapshot * refactor: fix segment constraints unsaved/editing state * refactor: remove create segment from mobile header menu * refactor: update segments form description * refactor: extract SegmentFormStepList component * refactor: add an optional FormTemplate docs link label * refactor: fix update segment payload * feat: finish edit component Co-authored-by: olav <mail@olav.io> * refactor: move step list above segment form * fix: update PR based on feedback Co-authored-by: olav <mail@olav.io> * refactor: fix constraint validation endpoint path * refactor: improve constraint state field name * refactor: extract AutocompleteBox component * feat: add strategy segment selection * refactor: add strategy segment previews * refactor: fix double section separator line * feat: disable deleting a usable segment * refactor: warn about segments without constraints * refactor: update text in delete segment dialogue * refactur: improve arg names * refactor: improve index var name * refactor: clarify steps list logic * refactor: use a required prop for the segment name * refactor: use ConditionallyRender for segment deletion * refactor: fix segments refetch * refactor: improve CreateUnleashContext component names * refactor: adjust segment form styles * refactor: adjust text * refactor: fix info icon tooltip hover target * refactor: add missing aria attrs to preview button * refactor: add strat name to delete segment modal * refactor: fix segment chip text alighment * refactor: use bulk endpoint for strategy segments * refactor: fix imports after merge Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com> Co-authored-by: olav <mail@olav.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #757
Beware, this adds the EmailService, but the templates are far from usable.