feat: add ui-bootstrap endpoint #790
Conversation
|
We should really discuss the types I've added to the services/stores and which ones we're exposing, I've done the minimum to make this work for now, but am prepared to add the extra elbow grease to pave the way for a smoother development experience further down the line. Also, for now had to add a @ts-ignore annotation to the call to our |
|
|
||
| private logger: Logger; | ||
|
|
||
| constructor(db: Knex, customContextFields, getLogger: LogProvider) { |
There was a problem hiding this comment.
What should be the type of customContextFields here?
There was a problem hiding this comment.
we should just remove these in v4. not needed when we have a proper API.
| this.db = db; | ||
| this.logger = getLogger('project-store.js'); | ||
| } | ||
|
|
||
| fieldToRow(data) { | ||
| fieldToRow(data): IProjectInsert { |
There was a problem hiding this comment.
What's the type of data? Bit surprised that typescript didn't warn me that data was untyped here.
- Reducing calls needed for frontend to 1 instead of the current 6 fixes: #789
* feat: add ui-bootstrap endpoint - Reducing calls needed for frontend to 1 instead of the current 6 fixes: #789
* refactor: preserve white-space in constraint values * refactor: deduplicate constraint values
fixes: #789