chore/enable publishing for python client 🎉 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Bring the publish step back to the speakeasy workflow, regenerate the github action with `speakeasy configure publishing` * Remove incorrect readme note about parent_id being disabled * Knock the package version back down to 0.23.0 for continuity with PyPI versions
awalker4
changed the title
|
Has the client been regenerated since the PR that changed the element types to a list of dicts? When testing on this branch I'm getting element objects that don't have any metadata (regardless of whether the pdf is being split by the client) |
|
Oof, great catch. The new openapi.json hasn't been deployed yet. We'll have to have this pr sit behind that, plus I'll add a unit test to check the output format. |
|
Okay, response schema fixed in #103. However, putting this on pause to figure out some page splitting issues. |
badGarnet
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
speakeasy configure publishing