Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set resolve_entities=False by default in lxml parser for partition_xml #3078

Closed
MthwRobinson opened this issue May 22, 2024 · 0 comments · Fixed by #3088
Closed

Set resolve_entities=False by default in lxml parser for partition_xml #3078

MthwRobinson opened this issue May 22, 2024 · 0 comments · Fixed by #3088

Comments

@MthwRobinson
Copy link
Contributor

The goal of this issue is to update partition_xml so that resolve_entities=False by default to avoid being injected in the XML file from external files.

References
@MthwRobinson MthwRobinson mentioned this issue May 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 23, 2024
@MthwRobinson
fix: set resolve_entities=False in partition_xml (#3088)
171b5df 
### Summary

Closes #3078. Sets `resolve_entities=False` for parsing XML with `lxml`
in `partition_xml` to avoid text being dynamically injected into the
document.

### Testing

`pytest test_unstructured/partition/test_xml.py` continues to pass with
the update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set resolve_entities=False in partition_xml Unstructured-IO/unstructured
1 participant
@MthwRobinson