Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new black changes #2473

Merged
merged 4 commits into from
Jan 30, 2024
Merged

chore: new black changes #2473

merged 4 commits into from
Jan 30, 2024

Conversation

qued
Copy link
Contributor

@qued qued commented Jan 29, 2024

Update black and apply changes to affected files. I separated this PR so we can have a look at the changes and decide whether we want to:

  1. Go forward with the new formatting
  2. Change the black config to make the old formatting valid
  3. Get rid of black entirely and just use ruff
  4. Do something I haven't thought of

@@ -6,4 +6,4 @@


def parse_xml(xml: Union[str, bytes]) -> etree._Element:
...
... # fmt: skip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a skip here, as the new black formatting conflicts with flake8 E701/E704 (see e.g. here). Resolving this doesn't seem as simple as ignoring these codes in flake8; my quick attempt at that caused several other flake8 errors to surface. I decided the easiest way forward would be to have black ignore affected lines.

@qued qued added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 007fc45 Jan 30, 2024
43 checks passed
@qued qued deleted the chore/new-black-changes branch January 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants