feat: include text from shapes in docx

[ds-filipknefel]

Reported bug: Text from docx shapes is not included in the partition output.
Fix: Extend docx partition to search for text tags nested inside structures responsible for creating the shape.

[ds-filipknefel]

@scanny

I've settled on this xpath for now: w:r/descendant::wp:inline[ancestor::w:drawing][1]//w:r

It'll find first occurence of w:drawing/wp:inline for each w:r directly under current paragraph and return w:r from inside it.

• Each single image should be contained within w:r directly under paragraph so I think w:r/ a reasonable limitation
• In case both choice and fallback use w:drawing (I think it's unlikely but maybe not impossible) we need to select the first one descendant::wp:inline[ancestor::w:drawing][1]
• We take wp:inline to only include inline shapes
• At the end I take w:r at the end because we want to use .text method of C_R the same way we do for other regions.

I've added two example documents and one test for each.

Also this was reported as a bug but I wonder if this should be considered a fix or a feature, what's your take? I'll update changelog accordingly.

[scanny]

A few remarks :)

[scanny]

Hi @ds-filipknefel that XPath expression looks good to me. I think the trailing //w:r is fine because the scope is so narrow by then that the search will be quick.

Btw, to understand the possible parent-child relationships in the XML you can consult the XML Schema for Open XML here: https://github.com/python-openxml/python-docx/blob/master/ref/xsd/wml.xsd. That said I feel pretty confident this XPath will do just what we want.

I'd call this a feature, albeit a small one. This is extending the range of what partition_docx() will detect. There are quite a few other corner-caes items it still won't detect and I don't believe we have either promised that it does or committed to make it do so (given the large engineering investment required). So I'd say we celebrate each new extension of its detection capability as a new goodness :)

[scanny]

Okay, I think this is good to go. One remark on test that can now be simplified.

If we're ready, you can change it from Draft to "ready" status and let me know and I'll approve it :)

[scanny]

Nice. Amazingly compact :)

One small nit but approving in advance.