feat: update dependencies and remove constraint on pydantic #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/drop-pydantic-constraint
branch
from
80464a8
to
7396c16
Compare
rbiseck3
changed the title
MthwRobinson
reviewed
Apr 3, 2024
MthwRobinson
approved these changes
Apr 3, 2024
rbiseck3
force-pushed
the
roman/drop-pydantic-constraint
branch
from
5ff9d85
to
89350d9
Compare
rbiseck3
force-pushed
the
roman/drop-pydantic-constraint
branch
from
41b57c3
to
155794d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
…ured-IO#2841) ### Description * The `consistent-deps.sh` was fixed to take into account the ingest dependencies, causing some errors to show up. New constriants were added to make that script pass. * Update all requirements without constraint on pydantic, allowing the latest version to be pulled in. * `pikepdf` is causing a conflict but there's a fix on their `main` branch, just need for the next release to be published. Opened up a question here to see if we can get that out any sooner: [Do releases happen on a schedule?](pikepdf/pikepdf#574). For now added `lxml<5` to the constraints. A couple optimizations: * `constraints.in` renamed to `constraints.txt` since the whole point is all dependencies are already pinned and the file never gets compiled * `constraints.txt` moved to a `requirements/deps` directory as this never gets compiled by `pip-compile` * Other dependency files updated to reference the new location of `base.in` and `constraints.txt` * make file updated since it was originally written to avoid the `base.in` and `constraints.in` file
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
…ured-IO#2841) ### Description * The `consistent-deps.sh` was fixed to take into account the ingest dependencies, causing some errors to show up. New constriants were added to make that script pass. * Update all requirements without constraint on pydantic, allowing the latest version to be pulled in. * `pikepdf` is causing a conflict but there's a fix on their `main` branch, just need for the next release to be published. Opened up a question here to see if we can get that out any sooner: [Do releases happen on a schedule?](pikepdf/pikepdf#574). For now added `lxml<5` to the constraints. A couple optimizations: * `constraints.in` renamed to `constraints.txt` since the whole point is all dependencies are already pinned and the file never gets compiled * `constraints.txt` moved to a `requirements/deps` directory as this never gets compiled by `pip-compile` * Other dependency files updated to reference the new location of `base.in` and `constraints.txt` * make file updated since it was originally written to avoid the `base.in` and `constraints.in` file
Coniferish
reviewed
Apr 19, 2024
| @@ -16,5 +16,5 @@ rapidfuzz | |||
| backoff | |||
| typing-extensions | |||
| # NOTE(jennings): pinned due to later versions not supporting api_key_auth in UnstructuredClient | |||
| unstructured-client>=0.15.1 | |||
There was a problem hiding this comment.
@rbiseck3, do you happen to remember why this version was restricted? The newer parameters of the client aren't accessible with this restricted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consistent-deps.shwas fixed to take into account the ingest dependencies, causing some errors to show up. New constriants were added to make that script pass.pikepdfis causing a conflict but there's a fix on theirmainbranch, just need for the next release to be published. Opened up a question here to see if we can get that out any sooner: Do releases happen on a schedule?. For now addedlxml<5to the constraints.A couple optimizations:
constraints.inrenamed toconstraints.txtsince the whole point is all dependencies are already pinned and the file never gets compiledconstraints.txtmoved to arequirements/depsdirectory as this never gets compiled bypip-compilebase.inandconstraints.txtbase.inandconstraints.infile