New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve load_requirements in setup.py #2861
Open
rbiseck3
wants to merge
11
commits into
main
Choose a base branch
from
roman/fix-setup-load-reqs
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qued
reviewed
Apr 5, 2024
qued
reviewed
Apr 5, 2024
rbiseck3
force-pushed
the
roman/fix-setup-load-reqs
branch
from
April 5, 2024 14:22
f5e1cb9
to
0649736
Compare
qued
reviewed
Apr 5, 2024
qued
reviewed
Apr 5, 2024
rbiseck3
force-pushed
the
roman/fix-setup-load-reqs
branch
from
April 9, 2024 14:29
af707ac
to
6efacb0
Compare
rbiseck3
force-pushed
the
roman/fix-setup-load-reqs
branch
from
April 15, 2024 18:01
6efacb0
to
b5bc1f5
Compare
@qued, repo uploaded to test pypi here: unstructured/0.13.3.dev3/. This breaks through because it looks for all subsequent dependencies from the same test pypi index and they don't all exist there (i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a number of enhancements around how we dynamically generate the requirements defined in the
setup.py
file. All logic around this was moved out into asetup_utils.py
file to support unit tests around the logic:load_requirements
: Current approach to dynamically generate the requirements was causing them to maintain the newline character at the end. This was removed. Also added support for the-r
character in*.in
files which recursively pull in other.in
files which would currently be ignored. This isn't being used at the moment so it wasn't causing a problem, but this is future looking. It also used to support a list of filenames but that was never used, isolated to take in only a string filename of a Path object..in
suffix.