Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use proper Astra env vars name to match internal docs #3179

Closed

Conversation

erichare
Copy link

Updates env var names to match Astra internal docs. Keeping as draft temporarily due to a 500 error which may or may not be related.

@erichare erichare marked this pull request as ready for review June 11, 2024 00:07
@erichare
Copy link
Author

@potter-potter I opened this pr first, before the refactored source connector PR (which i have ready) because this standardizes the environment variables to match what our other integrations do, as well as what our documentation lists as the astra variables, for the endpoint and token.

I hope i caught all the instances where this needs to change - let me know where i can open a corresponding PR for the docs if you'd like me too.

Sorry about the confusion on this, just thought it might be easier to address it now rather than later - i left a TODO item as a comment which is that, if desired, we could update the github secret to match the env var name - but (hopefully) this PR should work without that change as is.

@potter-potter
Copy link
Contributor

@erichare This seems fine. And thanks for adjusting the docs in our new Docs repo.

I'll add this to the Astra Source connector PR when it is created. Just to keep things simple.

@erichare
Copy link
Author

@erichare This seems fine. And thanks for adjusting the docs in our new Docs repo.

I'll add this to the Astra Source connector PR when it is created. Just to keep things simple.

Thanks so much. I’ll try to have that opened up today. Appreciate it.

@erichare erichare closed this Jun 25, 2024
@erichare erichare deleted the erichare/astra-env-vars branch June 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants