-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds data_source metadata to ElementMetadata #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These make abstractions make sense to me! ✅ |
add date properties
fix fetching of data source
cragwolfe
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add a few abstractions to the ingest base classes to support querying data and populating it when ingesting files. To do so we need to add a few optional fields in Element metadata to support tracking data source metadata:
This PR adds these fields to a new data_source field in ElementMetadata. It additionally an exists() property to the base IngestDoc definition. Subclasses should leverage record_locator to determine whether a given IngestDoc exists on the source.
bonus: bump dependencies (adds freezegun to validate date_processed functionality)
bonus: adds functionality to exclude nested metadata by dot notation
bonus: updates ingest fixtures to account for data_source field which is empty with addition of date_processed exclusion
Testing
Adds unit test coverage for data source metadata fields