Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

18 exec management page #36

Merged
merged 40 commits into from Aug 19, 2019
Merged

18 exec management page #36

merged 40 commits into from Aug 19, 2019

Conversation

rcalimuoguelph
Copy link
Contributor

Full e2e functionality for exec management page.

@rcalimuoguelph
added sass compiler and some scss classes
2425a87
@rcalimuoguelph
Changed styling of exec page
c75b6f6 
added stub data
@rcalimuoguelph
newExec form updates role when role selected
3fc7a47
@rcalimuoguelph
merged with master
de7b0fb
@rcalimuoguelph
admin exec template
6e46e2c 
fixed issue with rendering admin exec template
@rcalimuoguelph
functionality to validate duplicate admin exec
0cefafe 
fixed routing to admin-exec page
@rcalimuoguelph
admin_exec changes
ccda5f8 
added look and feel for adding and cancelling

removed emailDomain from ui-routes

added node-sass compiler
@rcalimuoguelph
some styling changes for add new exec
30e9bf0
@rcalimuoguelph
fixed missed illegal character
1dad272
@rcalimuoguelph
Merge remote-tracking branch 'origin' into 18-exec-management-page
07a5db0
@rcalimuoguelph
revert main page to not display admin on default
72f1de7
@rcalimuoguelph
Added possible route change for get exec
39fe12f
@rcalimuoguelph
added logic on front end to change routes
3495f4a
@rcalimuoguelph
add refresh of page on successful create
6e9e4f9
@rcalimuoguelph
added error logging and new route for adminExec
4433e32
@rcalimuoguelph
updated logic for adminExec page
ad53e46 
looks only up to the current cohort year and 5 years before
@rcalimuoguelph
fixed find function
ad26e2e
@rcalimuoguelph
updates to stylesheet
c9daa06
@rcalimuoguelph
Success and Error Modals
a1dbc0a 
adding create new execs functionality
styling updates
@rcalimuoguelph
Remove Functionality working
6a2acc3
@rcalimuoguelph
Added functionality to update execs
4b7e5a2
@rcalimuoguelph
styling changes for modal and updates for uiroute
448a70e
@rcalimuoguelph
Added helper to translate role values into name
b002b1b
@rcalimuoguelph rcalimuoguelph added the front-end User Interface label Aug 10, 2019
@rcalimuoguelph rcalimuoguelph added this to the Summer goals milestone Aug 10, 2019
@rcalimuoguelph
Copy link
Contributor Author

Merging is being blocked by linting error, im using a spread operator on ln 162 of models/exec/exec.js

MarshallAsch
MarshallAsch suggested changes Aug 11, 2019
View reviewed changes
router/ui-routes.js Show resolved Hide resolved
router/ui-routes.js Outdated Show resolved Hide resolved
router/ui-routes.js Outdated Show resolved Hide resolved
MarshallAsch
MarshallAsch suggested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@MarshallAsch MarshallAsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the couple comments and aside from those it looks good :)

views/helpers/handlebars.js Show resolved Hide resolved
MarshallAsch
MarshallAsch approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@MarshallAsch MarshallAsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is good now :)

@MarshallAsch MarshallAsch merged commit 6255fe8 into master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarshallAsch MarshallAsch MarshallAsch approved these changes

Assignees

@MarshallAsch MarshallAsch

Labels
front-end User Interface
Projects
None yet
Milestone
Summer goals
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcalimuoguelph @MarshallAsch