Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the googleFromUrl on the details page #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Lintokki
Copy link

@Lintokki Lintokki commented Apr 2, 2022

Description

Please include a summary of the change and which issue number is fixed (e.g. Fixes #1). Please also include relevant motivation and context.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Screenshots

Provide screenshots of what has been implemented. Leave blank if not applicable

Checklist

(Leave blank if not applicable)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@KirstyGong KirstyGong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some little changes

{
event.googleFormUrl ? <Link href={event.googleFormUrl} target="_blank">{event.googleFormUrl}</Link> : <Typography variant="body1" component="a">
{"You don't have any googleFormUrls"}
</Typography>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no google form, just return null. And also can you put "Please fill out this form:" in bold at front of the link.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants