Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hongchen Search Panel #132

Open
wants to merge 12 commits into
base: forum_page
Choose a base branch
from
Open

Hongchen Search Panel #132

wants to merge 12 commits into from

Conversation

Yae-Makoto
Copy link
Contributor

@Yae-Makoto Yae-Makoto commented Apr 15, 2022 •
edited
Loading

Description

props:


    hide = false, // show below
    searchInputLabel = "search", // little text above search input
    QRCode = "", // img link
    selectTermLabel,
    selectMonthLabel,
    selectPublisherLabel,
    selectTermItemList = ['test1', 'test2'], // select list 1
    selectMonthItemList = ['mtest1', 'mtest2'], // select list 2
    selectPublisherItemList = ['ptest1', 'ptest2'], // select list 3
    searchTip = "this is search tip", // select tooptip
    showADSTip = "Show More Filters",  // the label of  button that calls advanced search when it is hidden
    hideADSTip = "Hide Filters", // the label of button that hideadvanced search
    onSearch = ({ searchContent, searchTerm, searchMonth, searchPublisher }) => console.log(searchContent, searchTerm, searchMonth, searchPublisher) // calls when user press enter or click the icon

How has this been tested?

test mannualy

Screenshots

Capture43

hide = true

Capture1
Capture

hide = false

Capture4

Checklist

(Leave blank if not applicable)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

KirstyGong
KirstyGong requested changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@KirstyGong KirstyGong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, not everything need to be pass in

src/components/AdaptiveSearchPanel.js
selectTermItemList = ['test1', 'test2'],
selectMonthItemList = ['mtest1', 'mtest2'],
selectPublisherItemList = ['ptest1', 'ptest2'],
searchTip = "this is search tip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be pass in

src/components/AdaptiveSearchPanel.js
selectMonthItemList = ['mtest1', 'mtest2'],
selectPublisherItemList = ['ptest1', 'ptest2'],
searchTip = "this is search tip",
showADSTip = "Show More Filters",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be pass in

src/components/AdaptiveSearchPanel.js
selectPublisherItemList = ['ptest1', 'ptest2'],
searchTip = "this is search tip",
showADSTip = "Show More Filters",
hideADSTip = "Hide Filters",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be pass in

src/components/AdaptiveSearchPanel.js
import './AdaptiveSearchPanel.css'

export default function ({
hide = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check hide in here?

src/components/AdaptiveSearchPanel.js

export default function ({
hide = false,
searchInputLabel = "search",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be pass in

src/components/AdaptiveSearchPanel.js
hide = false,
searchInputLabel = "search",
QRCode = "https://demo.curlythemes.com/qr/wp-content/plugins/simple-qr/qr-generator.php?size=160&type=url&url=demo.curlythemes.com/qr",
selectTermLabel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be prop

src/components/AdaptiveSearchPanel.js
searchInputLabel = "search",
QRCode = "https://demo.curlythemes.com/qr/wp-content/plugins/simple-qr/qr-generator.php?size=160&type=url&url=demo.curlythemes.com/qr",
selectTermLabel,
selectMonthLabel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirstyGong KirstyGong KirstyGong requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yae-Makoto @KirstyGong @Alexl-268