Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventUI: Add sidebar to navigate between upcoming/past events #51

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

davidYichengWei
Copy link
Collaborator

Note: 🔺filed are required.

  • Summary 🔺

    • Modified font sizes, line heights and font weights to improve readabiulity
    • Added support for photo of event guests
    • Added a link for event registration
  • Issue Number 🔺 Events Page (UI)  #40

  • New Proposal

    • The original design of the event page was two tabs: Events This Year and Past Events, however, I think using Upcoming Events and Past Events makes more sense, as it makes it easier for people to see what events to expect in the future, and where o look for if they are looking for past events. Do you agree with this change? If so, I think we can remove the Event Replay accordion as well.

@CatherineZM
Copy link
Contributor

I think using Upcoming Events and Past Events makes more sense, as it makes it easier for people to see what events to expect in the future, and where o look for if they are looking for past events.

@davidYichengWei Good idea! What do you think if we add a tab on the side of the screen (like vertically) that says upcoming events and past events. And then inside past events we can have different years (similar to past projects) I feel like that would look nice. What do you think?

@davidYichengWei
Copy link
Collaborator Author

Hi @CatherineZM ,

Yeah, I think that will definitely look good. What I'm thinking is just that if I'm a person who just wants to learn about past events of VEEP, it might be easier for me if all events are displayed on one page sorted by date, than if I have to click on different years to view the past events. Splitting them into different years will definitely make the page more organized as we have more events in the future though. What are your thoughts on this? We can discuss this in the meeting later as well.

@CatherineZM
Copy link
Contributor

it might be easier for me if all events are displayed on one page sorted by date, than if I have to click on different years to view the past events.

@davidYichengWei That's true. We could just have a bigger title of what year the event is and have the list instead of accordion for now. But in the future when we have a lot more events, we can have an accordion instead

Copy link
Contributor

@CatherineZM CatherineZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@CatherineZM
Copy link
Contributor

@Felix-Deng @iiiizuo Take a look when you get a chance. If there's no more changes, you can merge it

@davidYichengWei davidYichengWei changed the title Yicheng: Event UI upgrade for upcoming events page EventUI: Add sidebar to navigate between upcoming/past events Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants