repl: improvements on user experience #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
Previously, when a user would submit an invalid value, we were setting the cursor to the start of line. Now we keep the cursor in the same place where it is left by the user. Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
When pressing enter in auto-complete text it will select a completion instead of submiting the value without completion. Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
Completions are now sorted by file type (first directories, than symbolic links and, finally, ordinary files). Also, we have added a slash to directories completions so it works nicely with the new enter key behaviour. Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.