config: improved updatehub credentials getter #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhu config main object has now 2 main methods, get_credentials and set_credentials, both used to get and set UpdateHub server access key and access secret. Config.get_credentials is able to get user credentials from environment (with UHU_ACCESS_ID and UHU_ACCESS_SECRET variables) and from ~/.uhu file. Environment variables are priorized. Also, get_credentials raises an error if no credential is provided. This helps clients to deal properly if users have not set its credentials. With this modifications all config module dependents (updatehub, repl and cli) were update to follow what is stated above. Signed-off-by: Pablo Palácios <ppalacios992@gmail.com>
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uhu config main object has now 2 main methods, get_credentials and
set_credentials, both used to get and set UpdateHub server access key
and access secret.
Config.get_credentials is able to get user credentials from
environment (with UHU_ACCESS_ID and UHU_ACCESS_SECRET variables) and
from ~/.uhu file. Environment variables are priorized. Also,
get_credentials raises an error if no credential is provided. This
helps clients to deal properly if users have not set its credentials.
With this modifications all config module dependents (updatehub, repl
and cli) were update to follow what is stated above.
Signed-off-by: Pablo Palácios ppalacios992@gmail.com