Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fec: forward RTCP to next pipe #481

Merged
merged 1 commit into from
May 11, 2018
Merged

fec: forward RTCP to next pipe #481

merged 1 commit into from
May 11, 2018

Conversation

funman
Copy link
Contributor

@funman funman commented May 11, 2018

We need the RTCP packets if next pipe is doing arq
We just avoid doing FEC on this stream

Note that this commit is not enough, when doing ARQ we also need to pass through the retransmits,
which have a different payload type.

Copy/pasting IRC:

16:40 < funman> we have 5 streams
16:41 < funman> #1 main rtp (PT 33 since it's mpeg-ts)
16:41 < funman> #2 & 3 : row / column rtp, on 2 other ports
16:41 < funman> #4 RTCP (see above patch)
16:41 < funman> #5 retransmits, using PT 97
16:42 < funman> so fec needs to let RTCP (detectable) and retransmits (not detectable without an SDP) go through
16:43 < funman> not sure where else we do this but we could count packets with a different PT and reset if e.g. >5
16:43 < funman> so once we see PT 33, let everything else go through
16:43 < funman> and if we get 5 consecutive rtp packets with another PT we issue a discontinuity and start using that one
16:55 < funman> some fec but no nack except that one at the start

We need the RTCP packets if next pipe is doing arq
We just avoid doing FEC on this stream
@cmassiot cmassiot merged commit 4b88520 into Upipe:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants