Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the RTCP packets if next pipe is doing arq
We just avoid doing FEC on this stream
Note that this commit is not enough, when doing ARQ we also need to pass through the retransmits,
which have a different payload type.
Copy/pasting IRC:
16:40 < funman> we have 5 streams
16:41 < funman> #1 main rtp (PT 33 since it's mpeg-ts)
16:41 < funman> #2 & 3 : row / column rtp, on 2 other ports
16:41 < funman> #4 RTCP (see above patch)
16:41 < funman> #5 retransmits, using PT 97
16:42 < funman> so fec needs to let RTCP (detectable) and retransmits (not detectable without an SDP) go through
16:43 < funman> not sure where else we do this but we could count packets with a different PT and reset if e.g. >5
16:43 < funman> so once we see PT 33, let everything else go through
16:43 < funman> and if we get 5 consecutive rtp packets with another PT we issue a discontinuity and start using that one
16:55 < funman> some fec but no nack except that one at the start