Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SignatureVersion 4 to support other regions #5

Closed
wants to merge 1 commit into from
Closed

Added SignatureVersion 4 to support other regions #5

wants to merge 1 commit into from

Conversation

Benzolitz
Copy link

Since only the regions added before 30th January 2014 support Version 2, it would not be possible to use this plugin with newer regions (i.e. eu-central-1). Source: http://stackoverflow.com/a/26538266

To add support for Version 4 only one parameter for the S3Bucket is needed. Source: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html#specify-signature-version

Since only the regions added before 30th January 2014 support Version 2, it would not be possible to use this plugin with newer regions (i.e. eu-central-1). Source: http://stackoverflow.com/a/26538266

To add support for Version 4 only one parameter for the S3Bucket is needed. Source: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html#specify-signature-version
@coveralls
Copy link

coveralls commented Nov 25, 2016

Coverage Status

Coverage remained the same at 99.091% when pulling 5586e64 on Benzolitz:patch-1 into 6944872 on Upplication:master.

@Souler
Copy link
Member

Souler commented Nov 25, 2016

I'm not sure if this is correct. According to the document you linked it states:

When using AWS SDKs that were released before May 2016, you may be required to request Signature Version 4 as shown in the following table:

But this module aws-sdk dependency version is ^2.5.5 which was released on Sept 9th. Have you updated to the latest version of gulp-elasticbeanstalk-deploy? If so an the problem persist, report it back and I will further look into it ;).

@Benzolitz
Copy link
Author

Hi, I must have overlooked that part. Nethertheless it doesn't work without the V4 signature.

I just started using this package today, so I have the latest version 1.0.5.

If I add my change locally to the aws.js file I can upload to beanstalk just fine. If I use the normal aws.js file I will get the error that I need to use V4.

@Souler
Copy link
Member

Souler commented Jan 10, 2017

Should be fixed by now, for any issues regarding this, comment it on #6.

@Souler Souler closed this Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants