RuntimeWarning: coroutine 'sleep' was never awaited.

[martyfay1]

Hey I very frequently see the mentioned RuntimeWarning above while trying to get_data from miners. The line of code that is responsible for it is pyasic/miners/base.py", lineno 432 api_command_task = asyncio.sleep(0). I'm not sure if it's me using the library wrong, or if this section of base.py can be refactored to eliminate the issue, or if this is a known issue etc. Here is what I'm doing:

async def _gather_and_handle(self, miner_ip: str) -> None:
        async with self.semaphore:
            miner: AnyMiner = await get_miner(miner_ip)
            if not miner:
                self._handle_none_miner(miner_ip)
                self.logger.debug(f"Miner at {miner_ip} was none.")
                return
            miner_data = None
            for attempt in range(self.timeout_retries):
                try:
                    async with asyncio.timeout(self.get_timeout):
                        miner_data = await miner.get_data()
                        break
                except TimeoutError:
                    if attempt < self.timeout_retries - 1:
                        self.logger.debug(f"Retrying {miner_ip}: Attempt {attempt + 1}")
                    else:
                        self.logger.info(f"Final retry failed for {miner_ip}")
                        self._handle_get_data_exception(
                            miner_ip, TimeoutError("Timeout reached")
                        )
                except Exception as e:
                    self.logger.debug(
                        f"Exception while getting data for ip: {miner_ip}, {type(e)}: {e}"
                    )
                    self._handle_get_data_exception(miner_ip, e)
            if miner_data:
                self._handle_got_data(miner_data)

I call this as follows:

 async with asyncio.TaskGroup() as tg:
            tasks = [
                tg.create_task(self._gather_and_handle(miner_ip))
                for miner_ip in miner_ips
            ]

Where miner_ips is just a list of ips that represent miners. Am I doing something wrong?

[b-rowan]

I don't think you're doing anything wrong here (although I prefer asyncio.gather() to TaskGroup since it's more compatible).

There's a good chance I can refactor to fix this, since that sleep(0) is just acting as a no-op in the case that there is either no RPC API commands or no web API commands. I'll try to write up a fix for this, you're welcome to open an issue if you want to.

[martyfay1]

Will do, thanks!