Meteor 1.8.0.1 with Angular 7.1.1 and Puppeteer #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
That's a great contribution! Thank you very much! |
|
Hi @georgyberdyshev , thank you so much for all those great contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ardatan and @Urigo,
this PR adds support for Meteor 1.8.0.1 with Angular 7.1.1 and use the Puppeteer headless browser
driver for testing. All dependencies have been updated to the latest versions.
rxjs-compat and underscore were removed as dependencies.
This also fixes #125
The work is based on my PR in:
Urigo/angular-meteor#1927
It would be great to have this merged quickly, as there are beneficial changes for many users.
Thanks, Georgy