NonEmptyString #512
Merged
NonEmptyString #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right. Contribution guide should be fixed! Thank you for reminding us and for this new scalar :) |
ardatan
force-pushed
the
non-empty-string
branch
from
524756f
to
1c164ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am suggesting this scalar type because it is one I often use in projects when I want to require a string to be present but also want to enforce a value in that string. This simply checks that
""and" "are invalid characters on input and that the string hold some value.I apologize if I missed something in the contribution guidelines, but the contribution link appears to be broken:
https://github.com/okgrow/guides/blob/master/open-source/contributing.md