Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 5] introduce helper to turbo train #6

Merged
merged 10 commits into from
May 15, 2023
Merged

[Issue 5] introduce helper to turbo train #6

merged 10 commits into from
May 15, 2023

Conversation

aablinov
Copy link
Collaborator

@aablinov aablinov commented May 11, 2023 •
edited

Description

  • Added full compatibility with rails Turbo::Broadcastable (with train_ prefix)
  • Added new test helpers and test server
  • Added ruby 3.2.2 to test matrix
  • Fixed all CI tests

Closes #5

@aablinov aablinov self-assigned this May 11, 2023
@aablinov aablinov changed the title Issue 5 introduce helper to turbo train [Issue 5] introduce helper to turbo train May 11, 2023
@aablinov aablinov marked this pull request as ready for review May 11, 2023 13:08
@aablinov aablinov requested a review from goodsign May 11, 2023 13:08
goodsign
goodsign approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@goodsign goodsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Amazing!
✅ I've checked the code, all looks good to me. Special bonus for fixing that spec thing
⚠️ I haven't been able to test this yet, so either let's wait, I could probably have more time next week, or, better, if you have already tested this in our app — let's merge, I trust you that it's working 🚀

@aablinov aablinov merged commit 5098d78 into main May 15, 2023
9 checks passed
@aablinov aablinov deleted the issue-5-introduce-helper-to-turbo-train branch May 15, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsign goodsign goodsign approved these changes

Assignees

@aablinov aablinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce helpers to turbo-train
2 participants
@aablinov @goodsign