Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure initializer + Add fanout to setup instruction #8

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

kuznetsovvl
Copy link
Collaborator

@kuznetsovvl kuznetsovvl commented Aug 24, 2023

2 issues are fixing here:

  • Current initialized confige should be under the block with setting server.
  • Readme doesn't have any word about fanout implementation

Should we add something about fanout into Configuration block in Readme?

P.S it's my first experience in contributing to gem, please, don't judge me strong 馃槃

README.md Outdated
@@ -57,6 +58,9 @@ Now you are ready to run 馃殌
```
caddy run
```
#### Fanout

[Fanout](https://fanout.io/) is a cloud platform. To use Fanout you must purchase a paid account with a contract for Fastly's services.
Copy link
Contributor

@savroff savroff Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to say that we only support the cloud version today. It would be nice if we could also extend the gem to support self-hosted Fanout.

README.md Show resolved Hide resolved
Co-authored-by: Nick Savrov <savroff@gmail.com>
Copy link
Contributor

@goodsign goodsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement! Looks good to me 馃憤

@kuznetsovvl kuznetsovvl merged commit 1092645 into main Sep 28, 2023
9 checks passed
@kuznetsovvl kuznetsovvl deleted the readme-add-fanout-to-setup-instruction branch September 28, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants