Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect when consent is denied - Part 2 #4

Closed
pi0neerpat opened this issue Dec 28, 2022 · 0 comments · Fixed by #20
Closed

Redirect when consent is denied - Part 2 #4

pi0neerpat opened this issue Dec 28, 2022 · 0 comments · Fixed by #20
Assignees

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Dec 28, 2022

Depends on #2

This behavior builds and depends on UseKeyp/oauth2-client-redwood#6

Since we are sitting in-between the social provider and the client app, we should not return the user to our home page. Instead they should be sent back to the client's redirect page.

When hitting cancel the user will be returned like:

http://localhost/redirect/node_oidc?error=access_denied&error_description=End-User%20aborted%20interaction&state=89a58ff8-b004-4b84-9dbe-b4a1a9775fd5%253AVbsSOj0H67Xzd4Io2mFGX

Then, take the state property, get the uid, and send the user to /oauth/interaction/:uid/abort to send them back to the client.

Note that original pattern in oauth2-client-redwood should still work, for cases when the login flow was not initiated by a client (eg. no uid in state)

jahabeebs added a commit that referenced this issue Jan 20, 2023
…name, etc.) (#22)

* added extra fields to payload and new front-end form fields

* lint fixes

* removed required validation and added null checking
jahabeebs added a commit that referenced this issue Jan 31, 2023
* added redirect logic when uid present

* lint

* new uid logic

* lint

* now parses encoded url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants