Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrudView should be supported #18

Open
1 of 7 tasks
Marlinc opened this issue Feb 28, 2016 · 8 comments
Open
1 of 7 tasks

CrudView should be supported #18

Marlinc opened this issue Feb 28, 2016 · 8 comments
Assignees
Milestone

Comments

@Marlinc
Copy link
Collaborator

Marlinc commented Feb 28, 2016

It should be possible to use CrudView with the Webservice plugin. For this quite a few things have to happen.

Some of the things that need to change:

  • FoC/Search should use the general repository interface: \Cake\Datasource\RepositoryInterface Make search manager use RepositoryInterface instance instead of Table. FriendsOfCake/search#79
  • \Search\Model\Behavior\SearchBehavior needs to be somehow compatible with \Muffin\Webservice\Model\Endpoint classes. Possibly by using traits. Interesting PR: Could we implement addBehavior()? cakephp/elastic-search#83.
  • Search Filter classes need to be less dependent on query expressions (at least simple cases like \Search\Model\Filter\Value). Currently the only way to use Search is to use the \Search\Model\Filter\Callback filter.
  • CrudView should use the general entity interface: \Cake\Datasource\EntityInterface (for example in the CrudViewHelper)
  • \Muffin\Webservice\Query needs to have the contain method
  • \Muffin\Webservice\Endpoint requires some notion of defining associations.

It might be necessary to change the CakePHP core to add more methods to specific interfaces. Some of the things that need to be made:

@Marlinc Marlinc self-assigned this Feb 28, 2016
@ADmad
Copy link
Member

ADmad commented Feb 28, 2016

FoC/Search should use the general repository interface: RepositoryInterface

You should open an issue (or PR) in it's own repo.

@Marlinc
Copy link
Collaborator Author

Marlinc commented Feb 28, 2016

Yea, I'm just trying to summarize what needs to happen. That's more than than that needs to happen.

@jadb
Copy link
Member

jadb commented Feb 28, 2016

👍

I would love this and could help on it as well.

Let me know what you need @Marlinc

@Marlinc
Copy link
Collaborator Author

Marlinc commented Feb 28, 2016

That's great @jadb! In general I'm trying to sum up all the things that are needed for this.

In general it would help individual people could work on the separate things that need to change.

@Phillaf
Copy link

Phillaf commented Feb 29, 2016

This is such a good idea! 👍

@jadb
Copy link
Member

jadb commented Feb 29, 2016

@Marlinc refer to the classes by FQDN so it's clear to the rest of us which Query for example you are talking about 😉

@Marlinc
Copy link
Collaborator Author

Marlinc commented Feb 29, 2016

@jadb there you go ;)

@Marlinc
Copy link
Collaborator Author

Marlinc commented May 31, 2016

I actually put a lot of work into this. I have a working setup with associations and CrudView working quite good. I'll try to get this work into the plugin in a month or so when I have time.

@Marlinc Marlinc added this to the 2.0 milestone May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants