Fixed function highlighting #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnitschke
commented
Apr 6, 2024
Comment on lines
+14
to
+15
| (((identifier) @function (#match? @function "^_?[a-z]")) | ||
| . (selector . (argument_part))) @function |
matthewnitschke
commented
Apr 6, 2024
| (expression_statement | ||
| (selector | ||
| (unconditional_assignable_selector | ||
| (identifier) @function)) |
There was a problem hiding this comment.
For now, I'm not worrying about annotating the differences between @function and @function.method
probably will look at this later, if it's considered beneficial
matthewnitschke
commented
Apr 6, 2024
| @@ -167,6 +190,7 @@ | |||
| (const_builtin) | |||
| (part_of_builtin) | |||
| (rethrow_builtin) | |||
| (void_type) | |||
There was a problem hiding this comment.
void is not really a type in dart, and most existing highlighting treats it as a keyword (thinking mostly the LSP syntax highlighting the vscode implements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlighting functions was fairly inconsistent, and utilized the not supported
@methodselectorThis PR reworks highlights.scm queries for functions, support different syntax highlighting for methods and properties, as well as function definitions and invocations
Before
After