Identify more system utilities #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a BSS symbol defined in the decomp.
These were found by correlating identical system code between EoS and Pokemon Heart Gold, for which various bits of library code (e.g., the Nitro SDK) are already known. This is the first of a series of results from this correlation work. Some of the changes included in this commit: - init code - math utilities for fixed-point numbers, vectors, and matrices - graphics utilities Note: GX_HBlankIntr is not the same between EoS and Heart Gold, but the label was added anyway because it is between GX_Init and GX_VBlankIntr in both games. The latter two functions DO match between games.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found by correlating identical system code between EoS and Pokemon Heart Gold, for which various bits of library code (e.g., the Nitro SDK) are already known.
This is the first of a series of results from this correlation work. Some of the changes included in this commit:
Note: GX_HBlankIntr is not the same between EoS and Heart Gold, but the label was added anyway because it is between GX_Init and GX_VBlankIntr in both games. The latter two functions DO match between games.