Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timer behaviour #108

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Conversation

KSSaiTeja
Copy link
Contributor

Related Issue

fixes: #106

Closes: #106

Describe the changes you've made

I have fixed the timer behaviour while multiple sounds are playing and also optimized the code

Give a clear description what modifications you have made

I have fixed the timer issue

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

I have locally tested it and verified. It works fine.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@vercel
Copy link

vercel bot commented Sep 15, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel.

@Utkarshn10 first needs to authorize it.

Copy link
Owner

@Utkarshn10 Utkarshn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KSSaiTeja here are some changes. Rest LGTM.

  1. Remove .vscode/settings.json

@KSSaiTeja
Copy link
Contributor Author

yeah sure, right away i will change, my editor did that.

@Utkarshn10 Utkarshn10 merged commit ac4437e into Utkarshn10:master Sep 16, 2023
1 of 2 checks passed
@Utkarshn10
Copy link
Owner

Thanks @KSSaiTeja for contributing :)

@KSSaiTeja
Copy link
Contributor Author

my pleasure..

And also i am interested to opensource and gSoc. could you please suggest me some good organisations based on javascript and reactjs and nextjs.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timer behavior fix
2 participants