Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduced the border radius of tabs button. #75

Merged

Conversation

giri-madhan
Copy link
Contributor

@giri-madhan giri-madhan commented May 3, 2023

Related Issue

Closes: #74

Describe the changes you've made

  • Reduced the border radius of the tabs.
  • Code is formatted using Prettier.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Screenshot 2023-05-03 at 2 59 49 PM Screenshot 2023-05-03 at 2 59 55 PM

@vercel
Copy link

vercel bot commented May 3, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel.

@Utkarshn10 first needs to authorize it.

@giri-madhan giri-madhan mentioned this pull request May 3, 2023
Copy link
Owner

@Utkarshn10 Utkarshn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @giri-madhan, we are using Chakra ui for the UI components and it already has a border radius property. It is preferred that we follow the older convention.

@giri-madhan
Copy link
Contributor Author

giri-madhan commented May 4, 2023

Hey @giri-madhan, we are using Chakra ui for the UI components and it already has a border radius property. It is preferred that we follow the older convention.

Hi @Utkarshn10, I have used borderRadius prop from Chakra UI and useTheme from @emotion package to change the border radius instead of custom CSS. Thank you for checking!

Copy link
Owner

@Utkarshn10 Utkarshn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giri-madhan for contributing to Focusly.

@Utkarshn10 Utkarshn10 merged commit 3002cb7 into Utkarshn10:master May 5, 2023
@giri-madhan giri-madhan deleted the fix/#74-change-tabs-design branch May 5, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Tab design
2 participants