Movie ListView re-use image downloading problem.

[JakeWharton]

Notice "Yoga Hosers" and "Clerks III" (maybe it's only Kevin Smith movies that have this problem!). This only happens when scrolling fast and the image for the original movie to which the poster belongs is not in the memory cache.

[JakeWharton]

Neither of these movies have posters. I forgot to mention that.

[JakeWharton]

Looks like the problem is in MoviesAdapter:

        if (!TextUtils.isEmpty(movie.poster_path)) {
            ServiceUtils.getPicasso(getContext())
                    .load(mImageBaseUrl + movie.poster_path)
                    .into(holder.poster);
        } else {
            // clear image
            holder.poster.setImageDrawable(null);
        }

You need to always call Picasso so that it knows the view was re-used.

The quick fix is to call ServiceUtils.getPicasso(getContext()).cancelRequest(holder.poster) in the else block. If movie.poster_path is null when a poster is not present, you can simply remove the if altogether. Picasso handles null URLs just fine.

[UweTrottmann]

Thanks for reporting and providing a fix!

P.S. Sorry for the late response, was a little under the weather the last
few days.

On Sun, Dec 21, 2014 at 10:42 AM, Jake Wharton notifications@github.com
wrote:

Looks like the problem is in MoviesAdapter:

    if (!TextUtils.isEmpty(movie.poster_path)) {
        ServiceUtils.getPicasso(getContext())
                .load(mImageBaseUrl + movie.poster_path)
                .into(holder.poster);
    } else {
        // clear image
        holder.poster.setImageDrawable(null);
    }

You need to always call Picasso so that it knows the view was re-used.

The quick fix is to call
ServiceUtils.getPicasso(getContext()).cancelRequest(holder.poster) in the
else block. If movie.poster_path is null when a poster is not present,
you can simply remove the if altogether. Picasso handles null URLs just
fine.

—
Reply to this email directly or view it on GitHub
#415 (comment)
.