Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error drawable for movie posters #486

Open
UweTrottmann opened this issue Mar 16, 2016 · 0 comments
Open

Show error drawable for movie posters #486

UweTrottmann opened this issue Mar 16, 2016 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed needs-info Needs more info to be worked on

Comments

@UweTrottmann
Copy link
Owner

When a movie poster can not be loaded (network failure or metered connection), display an error drawable like for show posters.

In MoviesAdapter and MoviesCursorAdapter use code like

ServiceUtils.loadWithPicasso(getContext(), item.poster)
                        .centerCrop()
                        .resizeDimen(R.dimen.movie_item_width, R.dimen.movie_item_poster_height)
                        .error(R.drawable.ic_image_missing)
                        .into(holder.poster);

This simple approach, however, is broken. The grid items are dynamically increased in width based on the available width of the GridView so R.dimen.movie_item_width is not always accurate.

movie-error-drawable

Issues

  • Figure out how to dynamically determine the actual width of a movie item.
@UweTrottmann UweTrottmann added enhancement New feature or request needs-info Needs more info to be worked on labels Mar 16, 2016
@UweTrottmann UweTrottmann added the help wanted Extra attention is needed label Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs-info Needs more info to be worked on
Projects
None yet
Development

No branches or pull requests

1 participant