Project Portfolio Mobile Responsive Pull Request #7
Conversation
There was a problem hiding this comment.
Hi @Uzair-Manzoor,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
- You have submitted a project, that was supposed to be done using pair programming but from your commit history, I can see you did it alone(solo). Please make sure to do the project with your coding partner before resubmitting your project for review. If you have any issues with your partner which is why you did the project solo then kindly contact Student Success at Success@microverse.org about the situation.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
There was a problem hiding this comment.
Hi team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Correct workflow ✔️
- HTML validations working as expected ✔️
- Formspree service integrated ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.html
Outdated
| <textarea | ||
| class="form_text_area" | ||
| name="message" | ||
| id="message" | ||
| placeholder="Write your message here" | ||
| maxlength="500" | ||
| required> | ||
| </textarea> |
There was a problem hiding this comment.
- You did a great job setting up HTML validations and integrating the Formspree service. 👍 Let's work on some minor details to achieve the project requirements.
- Currently, the placeholder of your
textareais not getting displayed because you have whitespaces between the opening and the closing tags of yourtextarea. Kindly fix it by removing the whitespace. 😎️ - Please decrease the spacing to the left and the right of the input fields as it seems to bit a bit bigger when compared to the design. 🤝️
- Kindly align the submit button to the left side as displayed on the design guideline. 🥸️
- Currently, the placeholder of your
| Your design | Figma design |
|---|---|
…o into mobile-responsive
There was a problem hiding this comment.
Hi @Uzair-Manzoor ,
Great work, your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Remember: Every finish line 🏁 is the beginning of a new race 🐎
Highlights
- Profesional README ✔️
- All linter checks are passing ✔️
- Requested change made ✔
- Correct GitHub flow ✔️
- Project up and running ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
|
Project has been updated according to the the given instructions;