Add all items counter on the Homepage - Student A #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Blaze
requested changes
Nov 24, 2022
There was a problem hiding this comment.
Required Changes ♻️
Hey @usamamaliq 👋
Highlights 🥇
✔️ Following GitHub Flow
✔️ Descriptive PR Summary
✔️ Descriptive PR Title
Please there are few UI related issues that needs to be fixed, See the inline Comments for further reference.
V-Blaze
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Hi @usamamaliq ,
STATUS: APPROVED ✔️ ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations and good job! 🎉
Highlights
- Good job fixing the required changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@V-Blaze,
In this pull request I have implemented an item counter and the result of the item counter is displayed on the menu bar. A separate module was created for the item counter and data was passed through DOM dynamically.
Regards,
Usama Masood