Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query parsing and compiling panic-free #38

Closed
V0ldek opened this issue Nov 13, 2022 · 0 comments · Fixed by #50
Closed

Make query parsing and compiling panic-free #38

V0ldek opened this issue Nov 13, 2022 · 0 comments · Fixed by #50
Assignees
@V0ldek
Labels
area: library Improvements to the library API quality type: reliability Tests, code quality
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Nov 13, 2022

Is your feature request related to a problem? Please describe.
The parser should use Error impls to handle errors, not unwrap (or expect).

Describe the solution you'd like
Remove all panics from the query module and enable clippy::unwrap_used and clippy::expect_used as warnings for the module.
@V0ldek V0ldek added type: feature New feature or request acceptance: go ahead Reviewed, implementation can start type: reliability Tests, code quality labels Nov 13, 2022
@V0ldek V0ldek self-assigned this Nov 13, 2022
@V0ldek V0ldek changed the title Make query parsing panic-free Make query parsing and compiling panic-free Nov 13, 2022
@V0ldek V0ldek added this to the v1.0.0 milestone Nov 13, 2022
This was referenced Nov 13, 2022
Closed
Merged
V0ldek added a commit that referenced this issue Nov 21, 2022
@V0ldek
lib: query module is now panic-free
54d7ae9 
All errors are now reported via `QueryError`.

Related: #38
@V0ldek V0ldek added mod: parser area: library Improvements to the library API quality and removed type: feature New feature or request acceptance: go ahead Reviewed, implementation can start labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
area: library Improvements to the library API quality type: reliability Tests, code quality
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

lib: query module is now panic-free rsonquery/rsonpath
1 participant
@V0ldek