Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove non division members & inactive members no state change #2799

Merged
merged 15 commits into from Dec 15, 2022

Conversation

AxonC
Copy link
Member

@AxonC AxonC commented Nov 23, 2022

Adds listeners to AccountAltered event, which, when triggered, will remove:

  • non-division members from waiting lists they are a part of on the first detection of a state other than Division
  • accounts marked as 'inactive', aka their rating becoming -1 internally.

When the removal happens, they will be sent an email depending on which condition they have no longer met to be on the waiting list.

Copy link
Contributor

@CalumTowers CalumTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just double check the consistency on the debug logs between the two listeners (e.g. the text that is logged and at one stage).

Otherwise I'm happy.

@AxonC
Copy link
Member Author

AxonC commented Nov 27, 2022

Can we just double check the consistency on the debug logs between the two listeners (e.g. the text that is logged and at one stage).

Otherwise I'm happy.

Good shout. Amended to have the best level of detail across the board.

@AxonC AxonC enabled auto-merge (squash) December 13, 2022 13:43
@AxonC AxonC requested a review from atoff December 15, 2022 09:14
@AxonC AxonC merged commit 3b3a8f2 into main Dec 15, 2022
@AxonC AxonC deleted the remove-non-division-members-waiting-list branch December 15, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants