Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Departure release request crash on acknowledge #289

Closed
AndyTWF opened this issue Jul 3, 2021 · 1 comment · Fixed by #292
Closed

Departure release request crash on acknowledge #289

AndyTWF opened this issue Jul 3, 2021 · 1 comment · Fixed by #292
Assignees
@AndyTWF
Labels
priority: now This is super urgent released type: bug Something isn't working

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Jul 3, 2021

ES crashes if you try to acknowledge a release
@AndyTWF AndyTWF added type: bug Something isn't working priority: now This is super urgent labels Jul 3, 2021
@AndyTWF AndyTWF self-assigned this Jul 3, 2021
AndyTWF added a commit to AndyTWF/uk-controller-plugin that referenced this issue Jul 3, 2021
@AndyTWF
fix(departure-releases): fix crash when acknowledging departure releases
80ddbb2 
Releases were being accessed by reference, which would go out of scope during the asynchronous task.

fix VATSIM-UK#289
@AndyTWF AndyTWF mentioned this issue Jul 3, 2021
Merged
AndyTWF added a commit that referenced this issue Jul 3, 2021
@AndyTWF
fix(departure-releases): fix crash when acknowledging departure relea…
41345f2 
…ses (#292)

Releases were being accessed by reference, which would go out of scope during the asynchronous task.

fix #289
VATSIMUK pushed a commit that referenced this issue Jul 3, 2021
@semantic-release-bot
chore(release): 3.1.3 [skip ci]
638a25e 
## [3.1.3](3.1.2...3.1.3) (2021-07-03)

### Bug Fixes

* **departure-releases:** fix colours in the release status view and add documentation ([#293](#293)) ([f6ba6a1](f6ba6a1)), closes [#290](#290)
* **departure-releases:** fix crash when acknowledging departure releases ([#292](#292)) ([41345f2](41345f2)), closes [#289](#289)
@VATSIMUK
Copy link

VATSIMUK commented Jul 3, 2021

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyTWF AndyTWF

Labels
priority: now This is super urgent released type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@AndyTWF @VATSIMUK