Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release requests in the past #297

Closed
AndyTWF opened this issue Jul 5, 2021 · 1 comment · Fixed by #298
Closed

Release requests in the past #297

AndyTWF opened this issue Jul 5, 2021 · 1 comment · Fixed by #298
Labels
priority: soon This is quite urgent, but not end of the world released type: bug Something isn't working

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Jul 5, 2021

If the user selects the "current time" for a release to become valid, it selects the start of the minute, which can lead to some interesting release validity periods!
@AndyTWF AndyTWF added type: bug Something isn't working priority: soon This is quite urgent, but not end of the world labels Jul 5, 2021
AndyTWF added a commit to AndyTWF/uk-controller-plugin that referenced this issue Jul 5, 2021
@AndyTWF
fix(departure-releases): treat releases at current minute as released…
e695665 
… at exactly now

If someone took 30 seconds to fill in the form for an immediate release, it would shave thirty
seconds off any expiry time. This change makes the plugin changed the released at time to "now" if
its in the past.

fix VATSIM-UK#297
@AndyTWF AndyTWF mentioned this issue Jul 5, 2021
Merged
AndyTWF added a commit that referenced this issue Jul 5, 2021
@AndyTWF
fix(departure-releases): treat releases at current minute as released…
3e1dd6e 
… at exactly now (#298)

If someone took 30 seconds to fill in the form for an immediate release, it would shave thirty
seconds off any expiry time. This change makes the plugin changed the released at time to "now" if
its in the past.

fix #297
VATSIMUK pushed a commit that referenced this issue Jul 5, 2021
@semantic-release-bot
chore(release): 3.1.4 [skip ci]
a537053 
## [3.1.4](3.1.3...3.1.4) (2021-07-05)

### Bug Fixes

* **departure-releases:** add acknowledgement colour for departure release status indicator ([#296](#296)) ([1afcc53](1afcc53)), closes [#295](#295)
* **departure-releases:** treat releases at current minute as released at exactly now ([#298](#298)) ([3e1dd6e](3e1dd6e)), closes [#297](#297)
@VATSIMUK
Copy link

VATSIMUK commented Jul 5, 2021

🎉 This issue has been resolved in version 3.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: soon This is quite urgent, but not end of the world released type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@AndyTWF @VATSIMUK