Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of concurrency protection on stands #310

Closed
AndyTWF opened this issue Aug 2, 2021 · 1 comment · Fixed by #311
Closed

Lack of concurrency protection on stands #310

AndyTWF opened this issue Aug 2, 2021 · 1 comment · Fixed by #311
Assignees
@AndyTWF
Labels
confirmed The issue has been confirmed as needing doing priority: now This is super urgent released type: bug Something isn't working

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Aug 2, 2021

  • When PluginEventsSynced fires, this happens outside normal ES flow. It clears the stand assignments. This can lead to a race condition and bad map access that could crash the plugin if you're unlucky.
  • Add synchronisation mechanisms.
@AndyTWF AndyTWF added type: bug Something isn't working priority: now This is super urgent confirmed The issue has been confirmed as needing doing labels Aug 2, 2021
@AndyTWF AndyTWF self-assigned this Aug 2, 2021
AndyTWF added a commit to AndyTWF/uk-controller-plugin that referenced this issue Aug 3, 2021
@AndyTWF
fix(stands): fix concurrency issues with stand assignments
538bd4e 
There are potential crash points due to lack of concurrency checking.

fix VATSIM-UK#310
@AndyTWF AndyTWF mentioned this issue Aug 3, 2021
Merged
AndyTWF added a commit that referenced this issue Aug 6, 2021
@AndyTWF
fix(stands): fix concurrency issues with stand assignments (#311)
35b9e2a 
There are potential crash points due to lack of concurrency checking.

fix #310
VATSIMUK pushed a commit that referenced this issue Aug 6, 2021
@semantic-release-bot
chore(release): 3.4.1 [skip ci]
b0512fb 
## [3.4.1](3.4.0...3.4.1) (2021-08-06)

### Bug Fixes

* **bootstrap:** fix euroscope crash in development mode ([#318](#318)) ([d66039d](d66039d)), closes [#317](#317)
* **edt:** fix timezone issue with estimated departure times ([#316](#316)) ([09396da](09396da)), closes [#190](#190)
* **push-events:** fix potential crash situation in push events ([#315](#315)) ([ff617be](ff617be)), closes [#313](#313)
* **stands:** fix concurrency issues with stand assignments ([#311](#311)) ([35b9e2a](35b9e2a)), closes [#310](#310)
@VATSIMUK
Copy link

VATSIMUK commented Aug 6, 2021

🎉 This issue has been resolved in version 3.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyTWF AndyTWF

Labels
confirmed The issue has been confirmed as needing doing priority: now This is super urgent released type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stands): fix concurrency issues with stand assignments AndyTWF/uk-controller-plugin
2 participants
@AndyTWF @VATSIMUK