Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After departure frequencies not updating #480

Closed
AndyTWF opened this issue Aug 10, 2022 · 4 comments · Fixed by #481
Closed

After departure frequencies not updating #480

AndyTWF opened this issue Aug 10, 2022 · 4 comments · Fixed by #481
Labels
released type: bug Something isn't working

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Aug 10, 2022

Situation at KK tonight:

Group of ODVIK departures, next frequency is INT
Another group, TC Bandbox

Investigate reasons why after departure frequencies may not be updating
@AndyTWF AndyTWF added the type: bug Something isn't working label Aug 10, 2022
@AndyTWF
Copy link
Contributor Author

AndyTWF commented Aug 10, 2022

THEORY:

  • Aircraft connects filing ADMAG, KK is on 08's, so ES does not resolve SIDs. Or maybe controllers setup is incorrect.
  • Resolver resolves with no SID hierarchy, with airfield hierarchy.
  • TC comes on
  • TC is in hierarchy for the SID, so it does a preceeds check. But because SID hierarchy is empty, this fails and therefore it keeps KK APP.

@AndyTWF
Copy link
Contributor Author

AndyTWF commented Aug 13, 2022

REPLICATED:

  • Connect to Vatsim with runway dialog set to 26L
  • Aircraft pops up with ODVIK (08R SID) flightplan
  • If KK APP is on, they become the after departure frequency
  • Change runways in active runway dialog to 08R
  • Doesn't matter who comes online, it's stuck on KK APP until a FP gets changed

@AndyTWF
Copy link
Contributor Author

AndyTWF commented Aug 13, 2022

Technically:

  • Resolve KK_APP on the basis of airfield handoff order.
  • Switch runways in dialog (no FP change)
  • Doesn't matter what happens active position wise, it gets stuck on KK APP

AndyTWF added a commit to AndyTWF/uk-controller-plugin that referenced this issue Aug 13, 2022
@AndyTWF
fix(handoff): departure frequencies not updating after runway dialog …
ad9b87b 
…change

Runway dialog changes do trigger a SID change, but do not trigger a FP change event.
This means the plugin does not update the departure frequencies of any FPs that had
an airfield resolved handoff, even if the new SID (after the runway dialog change) would
have had a different controller. This fixes that by clearing the handoff cache after
a runway dialog change.

fix VATSIM-UK#480
@AndyTWF AndyTWF mentioned this issue Aug 13, 2022
Merged
VATSIMUK pushed a commit that referenced this issue Aug 20, 2022
@semantic-release-bot
chore(release): 5.4.4 [skip ci]
9faa289 
## [5.4.4](5.4.3...5.4.4) (2022-08-20)

### Bug Fixes

* display redistributables warning on load error ([a37d810](a37d810))
* **handoff:** departure frequencies not updating after runway dialog change ([ad9b87b](ad9b87b)), closes [#480](#480)
* LoadPlugin error message ([5b74322](5b74322))
@VATSIMUK
Copy link

🎉 This issue has been resolved in version 5.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@AndyTWF @VATSIMUK